Things To Look Out For In Reviews: Revision history

27 June 2024

• curprev 12:5212:52, 27 June 2024‎ Marc Mutz talk contribs‎ 51,750 bytes +37‎ →‎Specifically QObject subclasses: if you don't re-use QObject::d_ptr, add a comment why.
• curprev 12:5012:50, 27 June 2024‎ Marc Mutz talk contribs‎ 51,713 bytes +435‎ →‎Specifically QObject subclasses: Mention https://wiki.qt.io/D-Pointer#Inheriting_d-pointers_for_optimization

21 June 2024

• curprev 21:0721:07, 21 June 2024‎ Marc Mutz talk contribs‎ 51,278 bytes +540‎ →‎Value Classes: mention another bug with exported non-polymorphic classes and the work-around macro
• curprev 20:5420:54, 21 June 2024‎ Marc Mutz talk contribs‎ 50,738 bytes +733‎ →‎Value Classes: give concrete examples of bugs and issues from exported non-polymorphic classes

20 June 2024

• curprev 09:1109:11, 20 June 2024‎ Marc Mutz talk contribs‎ m 50,005 bytes +71‎ →‎Special Member Functions: cross-link dtor to polymorphic classes

17 June 2024

• curprev 09:4109:41, 17 June 2024‎ Juha Vuolle talk contribs‎ 49,934 bytes −1‎ No edit summary Tag: Visual edit

11 June 2024

• curprev 11:3811:38, 11 June 2024‎ Marc Mutz talk contribs‎ 49,935 bytes +669‎ →‎Specifically QObject subclasses: Describe the order or elements in a QObject subclass

7 June 2024

• curprev 09:4909:49, 7 June 2024‎ Marc Mutz talk contribs‎ 49,266 bytes +176‎ →‎Commit Message: Mention
• curprev 09:4409:44, 7 June 2024‎ Marc Mutz talk contribs‎ 49,090 bytes −3‎ →‎Tests: Fix formatting and Q_COMPARE -> QCOMPARE

30 May 2024

• curprev 09:3009:30, 30 May 2024‎ Ahmad Samir talk contribs‎ m 49,093 bytes +158‎ Prefer Q_COMPARE_EQ with string lists

23 May 2024

• curprev 12:1012:10, 23 May 2024‎ Marc Mutz talk contribs‎ 48,935 bytes +288‎ →‎Naming Gotchas: Mutable.
• curprev 11:5011:50, 23 May 2024‎ Marc Mutz talk contribs‎ 48,647 bytes +358‎ →‎Polymorphic Classes: Mention that `final` on already `final` classes makes little sense.

16 May 2024

• curprev 06:0506:05, 16 May 2024‎ Marc Mutz talk contribs‎ 48,289 bytes +1,265‎ →‎Enums: Mention -Wswitch and that default: case labels disable it

15 May 2024

• curprev 15:3515:35, 15 May 2024‎ Marc Mutz talk contribs‎ 47,024 bytes +989‎ →‎QByteArray: new section on QBA
• curprev 12:1612:16, 15 May 2024‎ Marc Mutz talk contribs‎ 46,035 bytes +321‎ →‎Includes: Don't include qglobal.h anymore.

14 May 2024

• curprev 15:3315:33, 14 May 2024‎ Marc Mutz talk contribs‎ 45,714 bytes +65‎ →‎Methods: show that an rvalue-this overload should move out of the member variable

8 May 2024

• curprev 09:5009:50, 8 May 2024‎ Marc Mutz talk contribs‎ 45,649 bytes 0‎ →‎Canons: Give Mr. Lakos hi capital L back
• curprev 09:4809:48, 8 May 2024‎ Marc Mutz talk contribs‎ 45,649 bytes +669‎ →‎Canons: Add the absolute must-read C++ books: GoF, Refactoring , Sutter/Alexandrescu and Lakos

2 May 2024

• curprev 12:4112:41, 2 May 2024‎ Marc Mutz talk contribs‎ 44,980 bytes +123‎ →‎Naming Gotchas: Withdraw Status gotcha. I didn't read far enough...

1 May 2024

• curprev 09:0109:01, 1 May 2024‎ Marc Mutz talk contribs‎ 44,857 bytes +783‎ →‎API: Add new section with naming gotchas; incl. "status" and "iteratable"

29 April 2024

• curprev 15:1615:16, 29 April 2024‎ Marc Mutz talk contribs‎ 44,074 bytes +1,230‎ →‎Operators: Mention the fundamental relation between hash() and op==() and not to break it.

25 April 2024

• curprev 15:1015:10, 25 April 2024‎ Marc Mutz talk contribs‎ 42,844 bytes +1,621‎ →‎Class-Specific Usage Guidelines: Add items for QDebug / qWarning()
• curprev 11:4011:40, 25 April 2024‎ Marc Mutz talk contribs‎ 41,223 bytes +766‎ →‎Variables: Never use dynamically-sized containers for statically-sized data.
• curprev 11:2411:24, 25 April 2024‎ Marc Mutz talk contribs‎ 40,457 bytes +284‎ →‎Value Classes: mention that swapping should be done in declaration order

24 April 2024

• curprev 11:3211:32, 24 April 2024‎ Marc Mutz talk contribs‎ 40,173 bytes +375‎ →‎Methods: mention that when returning by const-&, also add a rvalue-this overload returning by value
• curprev 07:1907:19, 24 April 2024‎ Marc Mutz talk contribs‎ m 39,798 bytes +1‎ →‎API: fix a typo

19 April 2024

• curprev 14:2414:24, 19 April 2024‎ Marc Mutz talk contribs‎ 39,797 bytes +1,146‎ →‎Operators: mention we like hidden friends
• curprev 13:4513:45, 19 April 2024‎ Marc Mutz talk contribs‎ 38,651 bytes +909‎ →‎Gerrit: mention to prefer smaller patches; ok to ask to split, but not really to squash patches

12 April 2024

• curprev 12:0112:01, 12 April 2024‎ Marc Mutz talk contribs‎ m 37,742 bytes +3‎ →‎API: grammar fix
• curprev 11:5611:56, 12 April 2024‎ Marc Mutz talk contribs‎ 37,739 bytes +839‎ →‎API: Mention not to define symbols in a library X that don't reference types defined in X.

21 March 2024

• curprev 16:0916:09, 21 March 2024‎ Marc Mutz talk contribs‎ 36,900 bytes +620‎ →‎Value Classes: Mention to not export non-polymorphic classes wholesale.

17 March 2024

• curprev 08:3008:30, 17 March 2024‎ Marc Mutz talk contribs‎ 36,280 bytes +492‎ →‎RAII Classes: Mention that copying makes no sense for RAII objects.
• curprev 07:5607:56, 17 March 2024‎ Marc Mutz talk contribs‎ m 35,788 bytes 0‎ →‎Polymorphic Classes: Fix a typo.

15 March 2024

• curprev 07:1507:15, 15 March 2024‎ Marc Mutz talk contribs‎ 35,788 bytes +26‎ →‎std::numeric_limits: Mention that std::min/std::max also need to be protected with the parentheses trick.
• curprev 07:1407:14, 15 March 2024‎ Marc Mutz talk contribs‎ 35,762 bytes +66‎ →‎Polymorphic Classes: Move includemocs into QObject-specific subsection
• curprev 07:0907:09, 15 March 2024‎ Marc Mutz talk contribs‎ 35,696 bytes +972‎ →‎Polymorphic Classes: Add new subsecton about just QObject subclasses; mention to always put Q_OBJECT and always override event()

13 March 2024

• curprev 15:5215:52, 13 March 2024‎ Marc Mutz talk contribs‎ 34,724 bytes +2‎ →‎Commit Message: Fix link to Commit Message#Change Log
• curprev 08:0008:00, 13 March 2024‎ Marc Mutz talk contribs‎ 34,722 bytes −635‎ →‎Polymorphic Classes: We already had an item for not changing the access specifier
• curprev 07:5007:50, 13 March 2024‎ Marc Mutz talk contribs‎ 35,357 bytes +660‎ →‎Polymorphic Classes: Mention overrides shouldn't change access w/o at least a code comment.
• curprev 07:4007:40, 13 March 2024‎ Marc Mutz talk contribs‎ 34,697 bytes +4‎ Move "Classes with QProperty" to below "New classes".

12 March 2024

• curprev 19:2019:20, 12 March 2024‎ Marc Mutz talk contribs‎ 34,693 bytes +2‎ →‎Function Templates: fix section level
• curprev 19:1919:19, 12 March 2024‎ Marc Mutz talk contribs‎ 34,691 bytes +458‎ →‎Templates: New Section; mention explicitly specifying deducable template args is a smell

29 February 2024

• curprev 11:1611:16, 29 February 2024‎ Marc Mutz talk contribs‎ 34,233 bytes +453‎ →‎Enums: Mention adding RegisterEnumClassesUscoped to existing classes is SiC Type A and requires [ChangeLog]

27 February 2024

• curprev 10:5010:50, 27 February 2024‎ Marc Mutz talk contribs‎ 33,780 bytes +620‎ →‎Variables: Mention braces of braced initializers, and to prefer copy over direct initialization
• curprev 10:4210:42, 27 February 2024‎ Marc Mutz talk contribs‎ 33,160 bytes +583‎ →‎Includes: Mention rules around qNN header inclusions

23 February 2024

• curprev 11:1111:11, 23 February 2024‎ Marc Mutz talk contribs‎ 32,577 bytes +100‎ →‎Special Member Functions: SMFs and member swap() function argument are always called "other"
• curprev 10:2410:24, 23 February 2024‎ Marc Mutz talk contribs‎ 32,477 bytes +648‎ →‎Special Member Functions: Specify the two preferred orders of SMFs
• curprev 10:0010:00, 23 February 2024‎ Marc Mutz talk contribs‎ 31,829 bytes +544‎ →‎Methods: New section. Explain when and where to use the inline keyword.
• curprev 09:3609:36, 23 February 2024‎ Marc Mutz talk contribs‎ 31,285 bytes +982‎ →‎Move Semantics: Demote to subsubsection in a new Special Member Functions subsection. Add Contructors subsubsection, mention Q_IMPLICIT and that default ctors should be implicit.

20 February 2024

• curprev 10:0110:01, 20 February 2024‎ Ahmad Samir talk contribs‎ 30,303 bytes +487‎ QProperty FINAL