Improve API review process: Difference between revisions
Jump to navigation
Jump to search
(Created page with "Category:QtCS2023 ==Session Summary== ==Session Owners== ==Notes==") |
(→Notes) |
||
| Line 8: | Line 8: | ||
==Notes== | ==Notes== | ||
- API vs header review? Our header review has become an API review – or even an implementation review! | |||
- API design used to be: Go talk with Jasmine; but that doesn't scale. Do we need a group of reviewers? | |||
- How can we get people involved with API design earlier? | |||
+ tooling might help – Daniel has a bot for flagging changes | |||
+ add checks for common mistakes (boolean trap, naming of getters) | |||
+ but tooling won't solve a social issue | |||
Revision as of 13:53, 30 November 2023
Session Summary
Session Owners
Notes
- API vs header review? Our header review has become an API review – or even an implementation review! - API design used to be: Go talk with Jasmine; but that doesn't scale. Do we need a group of reviewers? - How can we get people involved with API design earlier?
+ tooling might help – Daniel has a bot for flagging changes + add checks for common mistakes (boolean trap, naming of getters) + but tooling won't solve a social issue