Things To Look Out For In Reviews: Revision history

31 January 2024

• curprev 16:1516:15, 31 January 2024‎ Marc Mutz talk contribs‎ 22,033 bytes +569‎ →‎Move Semantics: New section.
• curprev 15:5015:50, 31 January 2024‎ Marc Mutz talk contribs‎ 21,464 bytes +102‎ →‎Variables: Give more details on static constexpr variables' need to be defined in .cpp files, too.

30 January 2024

• curprev 19:3719:37, 30 January 2024‎ Marc Mutz talk contribs‎ 21,362 bytes +207‎ →‎Gerrit: trivial hashtag split into subtags

25 January 2024

• curprev 18:2318:23, 25 January 2024‎ Marc Mutz talk contribs‎ 21,155 bytes +85‎ →‎std classes That Shouldn't Be Used in Qt Implementation: fix typo, mention Integrity's problems with std::mutex/std::condition_variable.
• curprev 18:2118:21, 25 January 2024‎ Marc Mutz talk contribs‎ 21,070 bytes +405‎ →‎Class-Specific Usage Guidelines: reorder to be alphabetically-sorted, add QDateTime::currentDateTime()
• curprev 18:1318:13, 25 January 2024‎ Marc Mutz talk contribs‎ 20,665 bytes +3‎ →‎Gerrit: fix typo

24 January 2024

• curprev 12:1612:16, 24 January 2024‎ Ahmad Samir talk contribs‎ m 20,662 bytes +77‎ →‎Lambdas

23 January 2024

• curprev 14:4614:46, 23 January 2024‎ Marc Mutz talk contribs‎ 20,585 bytes +387‎ →‎Gerrit: On editing other people's commits.
• curprev 14:2814:28, 23 January 2024‎ Marc Mutz talk contribs‎ 20,198 bytes 0‎ →‎Specifically API Review: fix typo
• curprev 14:2514:25, 23 January 2024‎ Marc Mutz talk contribs‎ 20,198 bytes +2,573‎ →‎Gerrit: new section
• curprev 12:5512:55, 23 January 2024‎ Marc Mutz talk contribs‎ 17,625 bytes −13‎ →‎RAII Classes: fix link to QUIP-19
• curprev 11:1911:19, 23 January 2024‎ Marc Mutz talk contribs‎ 17,638 bytes +150‎ →‎RAII Classes: QUIP-19
• curprev 11:0611:06, 23 January 2024‎ Marc Mutz talk contribs‎ 17,488 bytes +536‎ →‎New Classes: includemocs
• curprev 10:4210:42, 23 January 2024‎ Marc Mutz talk contribs‎ 16,952 bytes +1,187‎ →‎Variables: new section
• curprev 08:1208:12, 23 January 2024‎ Marc Mutz talk contribs‎ 15,765 bytes +572‎ →‎Public Headers: Reimplementation of virtuals may not be called.

19 January 2024

• curprev 08:5308:53, 19 January 2024‎ Marc Mutz talk contribs‎ 15,193 bytes +171‎ →‎Class-Specific Usage Guidelines: (std::numeric_limits<int>::max)().
• curprev 08:1908:19, 19 January 2024‎ Marc Mutz talk contribs‎ 15,022 bytes +127‎ →‎Commit Message: Mention the two central questions a commit message must answer.
• curprev 08:1608:16, 19 January 2024‎ Marc Mutz talk contribs‎ 14,895 bytes +415‎ →‎Lambdas: Omit empty ().
• curprev 07:3107:31, 19 January 2024‎ Marc Mutz talk contribs‎ 14,480 bytes +178‎ →‎Deprecations and Removals: Mention QT_MOC_COMPAT
• curprev 07:2907:29, 19 January 2024‎ Marc Mutz talk contribs‎ m 14,302 bytes +14‎ →‎Deprecations and Removals: Make it clear the \note In Qt versions prior to ... applies to the docs of the function, not the function itself.

18 January 2024

• curprev 11:1811:18, 18 January 2024‎ Marc Mutz talk contribs‎ 14,288 bytes +591‎ →‎API: Don't use defaulted arguments of non-Trivial Type
• curprev 09:0909:09, 18 January 2024‎ Marc Mutz talk contribs‎ 13,697 bytes +469‎ →‎Timeouts: chrono-first

15 January 2024

• curprev 11:0811:08, 15 January 2024‎ Marc Mutz talk contribs‎ 13,228 bytes +1,257‎ →‎Class-Specific Usage Guidelines: Add a list of classes to avoid in Qt's own implementation
• curprev 10:5410:54, 15 January 2024‎ Marc Mutz talk contribs‎ 11,971 bytes +175‎ →‎Value Classes: Don't use QSharedPointer for d-pointer.
• curprev 06:1906:19, 15 January 2024‎ Marc Mutz talk contribs‎ 11,796 bytes +567‎ →‎Includes: Include what you need, fwd-declare the rest.

12 January 2024

• curprev 09:0309:03, 12 January 2024‎ Marc Mutz talk contribs‎ 11,229 bytes +1,635‎ Add section on lambdas and their naming.
• curprev 08:3708:37, 12 January 2024‎ Marc Mutz talk contribs‎ 9,594 bytes +1,180‎ →‎Newly-Added Things: Add section on commit messages.

11 January 2024

• curprev 15:0915:09, 11 January 2024‎ Marc Mutz talk contribs‎ 8,414 bytes +995‎ swapping, move SMFs, Q_DISABLE_COPY_MOVE
• curprev 12:1212:12, 11 January 2024‎ Marc Mutz talk contribs‎ 7,419 bytes +438‎ create() vs. createFoo()
• curprev 08:2308:23, 11 January 2024‎ Marc Mutz talk contribs‎ 6,981 bytes +631‎ Add section on std::optional
• curprev 08:1508:15, 11 January 2024‎ Marc Mutz talk contribs‎ 6,350 bytes +119‎ De-meta-isise "Deprecations and Removal" =sections= are about the document itself, all guidelines are to be added to "Newly-Added Things". Add request for QT_REMOVED_SINCE \note for prior Qt versions.

10 January 2024

• curprev 09:0109:01, 10 January 2024‎ Marc Mutz talk contribs‎ 6,231 bytes +788‎ →‎Enums: Type of enum; 0 should mean "default".
• curprev 08:5108:51, 10 January 2024‎ Marc Mutz talk contribs‎ 5,443 bytes +2‎ →‎New Classes: drag documentation out of Value Classes into it's own subsubsection Tag: Visual edit: Switched
• curprev 08:4808:48, 10 January 2024‎ Marc Mutz talk contribs‎ 5,441 bytes +123‎ Namespaces are QtFoo, not QFoo.

9 January 2024

• curprev 17:3117:31, 9 January 2024‎ Marc Mutz talk contribs‎ 5,318 bytes +52‎ →‎New Classes: add structure with subsections for value and RAII classes
• curprev 17:2917:29, 9 January 2024‎ Marc Mutz talk contribs‎ 5,266 bytes +672‎ →‎New Classes: Q_DECLARE_SHARED, Q_DECLARE_METATYPE, Rationale for not using QSDP.
• curprev 17:2217:22, 9 January 2024‎ Marc Mutz talk contribs‎ 4,594 bytes +184‎ →‎New Classes: Don't use QSDP anymore, use QESDP.
• curprev 16:4916:49, 9 January 2024‎ Marc Mutz talk contribs‎ 4,410 bytes +544‎ Add section on canons.

5 January 2024

• curprev 12:2112:21, 5 January 2024‎ Marc Mutz talk contribs‎ 3,866 bytes +631‎ Includes.
• curprev 11:4311:43, 5 January 2024‎ Marc Mutz talk contribs‎ m 3,235 bytes +8‎ →‎New Classes
• curprev 11:4211:42, 5 January 2024‎ Marc Mutz talk contribs‎ 3,227 bytes +6‎ →‎Enums: \value applies to enum_erators_, not enums.
• curprev 11:4211:42, 5 January 2024‎ Marc Mutz talk contribs‎ 3,221 bytes +425‎ Mention to not move code around in public headers.
• curprev 11:3311:33, 5 January 2024‎ Marc Mutz talk contribs‎ m 2,796 bytes 0‎ →‎Polymorphic Classes: Fix itemizaton
• curprev 09:3809:38, 5 January 2024‎ Kkoehne talk contribs‎ 2,796 bytes +1,209‎ Added documentation hints
• curprev 09:2909:29, 5 January 2024‎ EdwardWelbourne talk contribs‎ 1,587 bytes +19‎ Commit Policy is another potential destination for these.
• curprev 09:2709:27, 5 January 2024‎ EdwardWelbourne talk contribs‎ m 1,568 bytes −2‎ bah - too many colons.
• curprev 09:2709:27, 5 January 2024‎ EdwardWelbourne talk contribs‎ 1,570 bytes +84‎ More categories, add the highly relevant Review Policy page to the candidate places to move things once settled.
• curprev 08:3708:37, 5 January 2024‎ Marc Mutz talk contribs‎ m 1,486 bytes +6‎ Fix internal links
• curprev 08:3608:36, 5 January 2024‎ Marc Mutz talk contribs‎ 1,480 bytes +379‎ Start section on new classes
• curprev 08:1808:18, 5 January 2024‎ Marc Mutz talk contribs‎ 1,101 bytes +1,101‎ Created.