Improve API review process: Difference between revisions

From Qt Wiki
Jump to navigation Jump to search
(Created page with "Category:QtCS2023 ==Session Summary== ==Session Owners== ==Notes==")
 
m (→‎Notes: Fix markup)
 
(One intermediate revision by one other user not shown)
Line 8: Line 8:


==Notes==
==Notes==
* API vs header review? Our header review has become an API review – or even an implementation review!
* API design used to be: Go talk  with Jasmine; but that doesn't scale. Do we need a group of reviewers?
* How can we get people involved with API design earlier?
** tooling might help – Daniel has a  bot for flagging changes
** add checks for common mistakes (boolean trap, naming of getters)
** but tooling won't solve a social issue

Latest revision as of 15:42, 30 November 2023


Session Summary

Session Owners

Notes

  • API vs header review? Our header review has become an API review – or even an implementation review!
  • API design used to be: Go talk with Jasmine; but that doesn't scale. Do we need a group of reviewers?
  • How can we get people involved with API design earlier?
    • tooling might help – Daniel has a bot for flagging changes
    • add checks for common mistakes (boolean trap, naming of getters)
    • but tooling won't solve a social issue